juan.zapata/repuve-backend-v1
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: cancelación de constancia pdf dañado

Browse Source
This commit is contained in:
Juan Felipe Zapata Moreno 2025-12-26 16:45:06 -06:00
parent 1b2522c4f0
commit d3bd94e158
1 changed files with 48 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
app/Http/Controllers/Repuve/CancellationController.php
View File

@ -4,7 +4,7 @@
use App\Http\Controllers\Controller;
use App\Http\Requests\Repuve\CancelConstanciaRequest;
use App\Models\CatalogCancellationReason;
use Illuminate\Validation\ValidationException;
use App\Models\Record;
use App\Models\Tag;
use App\Models\TagCancellationLog;
@ -287,9 +287,18 @@ public function cancelarTagNoAsignado(Request $request)
'cancelled_by' => Auth::id(),
]);
// Cargar las relaciones necesarias
// Cargar las relaciones necesarias ANTES de usarlas
$cancellationLog->load(['cancellationReason', 'cancelledBy']);
// Validar que la relación se cargó correctamente
if (!$cancellationLog->cancellationReason) {
DB::rollBack();
return ApiResponse::INTERNAL_ERROR->response([
'message' => 'Error al cargar el motivo de cancelación.',
'error' => 'La relación cancellationReason no se pudo cargar correctamente.',
]);
}
// Actualizar el módulo del tag si se proporciona
if ($request->filled('module_id')) {
$tag->module_id = $request->module_id;
@ -301,7 +310,6 @@ public function cancelarTagNoAsignado(Request $request)
DB::commit();
try {
// Recargar el tag con sus relaciones actualizadas
$tag->load(['status', 'cancellationLogs.cancellationReason', 'cancellationLogs.cancelledBy', 'module']);
@ -326,6 +334,7 @@ public function cancelarTagNoAsignado(Request $request)
'ubicacion' => $tag->module ? $tag->module->address : 'No especificado',
];
try {
$pdf = Pdf::loadView('pdfs.tag', [
'cancellation' => $cancellationData,
])
@ -338,32 +347,23 @@ public function cancelarTagNoAsignado(Request $request)
return $pdf->stream('constancia_cancelada_' . ($tag->tag_number ?? $tag->folio) . '.pdf');
} catch (\Exception $e) {
// Si falla la generación del PDF, devolver respuesta JSON
Log::error('Error al generar PDF de tag cancelado: ' . $e->getMessage());
return ApiResponse::OK->response([
'message' => 'Tag cancelado exitosamente (Error al generar PDF)',
'tag' => [
'id' => $tag->id,
'tag_number' => $tag->tag_number,
'folio' => $tag->folio,
'previous_status' => 'Disponible',
'new_status' => 'Dañado',
],
'cancellation' => [
'id' => $cancellationLog->id,
'reason' => $cancellationLog->cancellationReason->name,
'observations' => $cancellationLog->cancellation_observations,
'cancelled_at' => $cancellationLog->cancellation_at->toDateTimeString(),
'cancelled_by' => Auth::user()->name,
],
'pdf_error' => $e->getMessage(),
// Retornar error como JSON
return ApiResponse::INTERNAL_ERROR->response([
'message' => 'Tag cancelado pero error al generar PDF',
'error' => $e->getMessage(),
]);
}
} catch (ValidationException $e) {
// Errores de validación
return ApiResponse::BAD_REQUEST->response([
'message' => 'Error de validación',
'errors' => $e->errors(),
]);
} catch (\Exception $e) {
DB::rollBack();
return ApiResponse::BAD_REQUEST->response([
return ApiResponse::INTERNAL_ERROR->response([
'message' => 'Error al cancelar el tag',
'error' => $e->getMessage(),
]);