From 47cc7cdb8e29179821332875597edab86808d9bc Mon Sep 17 00:00:00 2001
From: "edgar.mendez" <edgar.mendez@gmail.com>
Date: Sat, 21 Mar 2026 20:49:01 -0600
Subject: [PATCH] feat(units): add permission checks for unit management
 actions in Units component

---
 src/components/layout/Sidebar.vue             |  13 ++-
 .../catalog/components/units/Units.vue        | 102 ++++++++++++++++--
 2 files changed, 107 insertions(+), 8 deletions(-)

diff --git a/src/components/layout/Sidebar.vue b/src/components/layout/Sidebar.vue
index 9a34fb0..8929e0c 100644
--- a/src/components/layout/Sidebar.vue
+++ b/src/components/layout/Sidebar.vue
@@ -25,7 +25,18 @@ const menuItems = ref<MenuItem[]>([
         label: 'Catálogo',
         icon: 'pi pi-book',
         items: [
-            { label: 'Unidades de Medida', icon: 'pi pi-calculator', to: '/catalog/units-of-measure' },
+            {
+                label: 'Unidades de Medida',
+                icon: 'pi pi-calculator',
+                to: '/catalog/units-of-measure',
+                permission: [
+                    'units-of-measure.index',
+                    'units-of-measure.show',
+                    'units-of-measure.store',
+                    'units-of-measure.update',
+                    'units-of-measure.destroy',
+                ],
+            },
             { label: 'Clasificaciones Comerciales', icon: 'pi pi-tags', to: '/catalog/classifications-comercial' },
             { label: 'Proveedores', icon: 'pi pi-briefcase', to: '/catalog/suppliers' },
             { label: 'Documentos del Modelo', icon: 'pi pi-file', to: '/catalog/model-documents' },
diff --git a/src/modules/catalog/components/units/Units.vue b/src/modules/catalog/components/units/Units.vue
index ae09f1a..c18fa5d 100644
--- a/src/modules/catalog/components/units/Units.vue
+++ b/src/modules/catalog/components/units/Units.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { ref, computed, onMounted } from 'vue';
+import { ref, computed, watch } from 'vue';
 import { useRouter } from 'vue-router';
 import { useToast } from 'primevue/usetoast';
 import { useConfirm } from 'primevue/useconfirm';
@@ -17,11 +17,13 @@ import Select from 'primevue/select';
 import { useUnitOfMeasureStore } from '../../stores/unitOfMeasureStore';
 import UnitsForm from './UnitsForm.vue';
 import type { UnitOfMeasure, CreateUnitOfMeasureData } from '../../types/unit-measure.interfaces';
+import { useAuth } from '@/modules/auth/composables/useAuth';
 
 const router = useRouter();
 const toast = useToast();
 const confirm = useConfirm();
 const unitStore = useUnitOfMeasureStore();
+const { hasPermission } = useAuth();
 
 // Breadcrumb
 const breadcrumbItems = ref([
@@ -57,6 +59,19 @@ const getStatusConfig = (isActive: boolean) => {
         : { label: 'Inactiva', severity: 'secondary' };
 };
 
+const canViewUnits = computed(() =>
+    hasPermission([
+        'units-of-measure.index',
+        'units-of-measure.show',
+        'units-of-measure.store',
+        'units-of-measure.update',
+        'units-of-measure.destroy',
+    ])
+);
+const canCreateUnit = computed(() => hasPermission('units-of-measure.store'));
+const canUpdateUnit = computed(() => hasPermission('units-of-measure.update'));
+const canDeleteUnit = computed(() => hasPermission('units-of-measure.destroy'));
+
 // Methods
 const buildFilters = () => ({
     paginate: true,
@@ -66,6 +81,11 @@ const buildFilters = () => ({
 });
 
 const loadUnits = async (force = false) => {
+    if (!canViewUnits.value) {
+        unitStore.clearUnits();
+        return;
+    }
+
     await unitStore.fetchUnits({
         force,
         ...buildFilters(),
@@ -73,12 +93,30 @@ const loadUnits = async (force = false) => {
 };
 
 const openCreateDialog = () => {
+    if (!canCreateUnit.value) {
+        toast.add({
+            severity: 'warn',
+            summary: 'Sin permisos',
+            detail: 'No tienes permisos para crear unidades de medida.',
+            life: 4000,
+        });
+        return;
+    }
     isEditing.value = false;
     selectedUnit.value = null;
     showDialog.value = true;
 };
 
 const openEditDialog = (unit: UnitOfMeasure) => {
+    if (!canUpdateUnit.value) {
+        toast.add({
+            severity: 'warn',
+            summary: 'Sin permisos',
+            detail: 'No tienes permisos para actualizar unidades de medida.',
+            life: 4000,
+        });
+        return;
+    }
     isEditing.value = true;
     selectedUnit.value = unit;
     showDialog.value = true;
@@ -107,8 +145,14 @@ const handleUpdateUnit = async (id: number, data: CreateUnitOfMeasureData) => {
 const handleSaveUnit = async (data: CreateUnitOfMeasureData) => {
     try {
         if (isEditing.value && selectedUnit.value) {
+            if (!canUpdateUnit.value) {
+                throw new Error('without-update-permission');
+            }
             await handleUpdateUnit(selectedUnit.value.id, data);
         } else {
+            if (!canCreateUnit.value) {
+                throw new Error('without-create-permission');
+            }
             await handleCreateUnit(data);
         }
 
@@ -119,6 +163,7 @@ const handleSaveUnit = async (data: CreateUnitOfMeasureData) => {
         console.error('Error saving unit:', error);
 
         const requestError = error as {
+            message?: string;
             response?: {
                 status?: number;
                 data?: {
@@ -143,13 +188,28 @@ const handleSaveUnit = async (data: CreateUnitOfMeasureData) => {
         toast.add({
             severity: 'error',
             summary: 'Error',
-            detail: requestError.response?.data?.message || 'No se pudo guardar la unidad de medida. Por favor, intenta nuevamente.',
+            detail:
+                requestError.response?.data?.message ||
+                (requestError.message === 'without-update-permission'
+                    ? 'No tienes permisos para actualizar unidades de medida.'
+                    : requestError.message === 'without-create-permission'
+                        ? 'No tienes permisos para crear unidades de medida.'
+                        : 'No se pudo guardar la unidad de medida. Por favor, intenta nuevamente.'),
             life: 3000,
         });
     }
 };
 
 const confirmDelete = (unit: UnitOfMeasure) => {
+    if (!canDeleteUnit.value) {
+        toast.add({
+            severity: 'warn',
+            summary: 'Sin permisos',
+            detail: 'No tienes permisos para eliminar unidades de medida.',
+            life: 4000,
+        });
+        return;
+    }
     confirm.require({
         message: `¿Estás seguro de eliminar la unidad de medida "${unit.name}"?`,
         header: 'Confirmar Eliminación',
@@ -162,6 +222,15 @@ const confirmDelete = (unit: UnitOfMeasure) => {
 };
 
 const deleteUnit = async (id: number) => {
+    if (!canDeleteUnit.value) {
+        toast.add({
+            severity: 'warn',
+            summary: 'Sin permisos',
+            detail: 'No tienes permisos para eliminar unidades de medida.',
+            life: 4000,
+        });
+        return;
+    }
     try {
         await unitStore.deleteUnit(id);
         await loadUnits(true);
@@ -192,10 +261,17 @@ const clearFilters = async () => {
     await loadUnits(true);
 };
 
-// Lifecycle
-onMounted(async () => {
-    await loadUnits();
-});
+watch(
+    () => canViewUnits.value,
+    async (allowed) => {
+        if (allowed) {
+            await loadUnits();
+        } else {
+            unitStore.clearUnits();
+        }
+    },
+    { immediate: true }
+);
 </script>
 
 <template>
@@ -228,6 +304,7 @@ onMounted(async () => {
                     Unidades de Medida
                 </h1>
                 <Button
+                    v-if="canCreateUnit"
                     label="Nueva Unidad"
                     icon="pi pi-plus"
                     @click="openCreateDialog"
@@ -236,7 +313,7 @@ onMounted(async () => {
         </div>
 
         <!-- Main Card -->
-        <Card>
+        <Card v-if="canViewUnits">
             <template #content>
                 <div class="flex flex-col md:flex-row md:items-end gap-3 mb-4">
                     <div class="flex-1">
@@ -341,6 +418,7 @@ onMounted(async () => {
                         <template #body="slotProps">
                             <div class="flex gap-2">
                                 <Button
+                                    v-if="canUpdateUnit"
                                     icon="pi pi-pencil"
                                     text
                                     rounded
@@ -349,6 +427,7 @@ onMounted(async () => {
                                     v-tooltip.top="'Editar'"
                                 />
                                 <Button
+                                    v-if="canDeleteUnit"
                                     icon="pi pi-trash"
                                     text
                                     rounded
@@ -369,6 +448,15 @@ onMounted(async () => {
             </template>
         </Card>
 
+        <Card v-else>
+            <template #content>
+                <div class="text-center py-10 text-surface-500 dark:text-surface-400">
+                    <i class="pi pi-lock text-4xl mb-3"></i>
+                    <p>No tienes permisos para visualizar este módulo.</p>
+                </div>
+            </template>
+        </Card>
+
         <!-- Create/Edit Form Dialog -->
         <UnitsForm
             ref="unitsFormRef"